Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 3 buttons to the textEditView that allow quickly adding new items #690

Merged

Conversation

nagolinc
Copy link
Contributor

Thought this would be handy so you can quickly create characters/plots/world items from the editor.

  1. Select text of name of the object you want to create in the textEdit view
  2. Right click
  3. Click on the type of object you want to create

@TheJackiMonster TheJackiMonster self-assigned this Feb 19, 2021
@TheJackiMonster
Copy link
Collaborator

This merge request needs to be rebased to the current state or at least the latest release. The models could potentially be different.

Also when I try to add a character, the whole applications crashes currently on my system without specifying the exact issue.

Fatal Python error: Aborted

Current thread 0x00007f35a80cd740 (most recent call first):
File "/home/thejackimonster/github/manuskript/bin/../manuskript/main.py", line 221 in launch
File "/home/thejackimonster/github/manuskript/bin/../manuskript/main.py", line 234 in run
File "/home/thejackimonster/github/manuskript/bin/manuskript", line 13 in

@nagolinc
Copy link
Contributor Author

Thanks for looking at this! I think the bug should be fixed now!

@TheJackiMonster
Copy link
Collaborator

I assume the problem wasn't the missing value because you have added default values already and it's still crashing. ^^'

@TheJackiMonster
Copy link
Collaborator

Ok, the issue seems to be fixed. Now I have one thing which would be great to work properly:

  • When I right-click on a word to automatically select the word and open the context menu, your actions don't appear.

I think if this would work, the commits only need to be squashed to one then I could merge it.

@TheJackiMonster
Copy link
Collaborator

Ok, I have fixed some problems related to the automatic selection of words. If you squash the commits I can just merge it. The problem I had should then also be solved.

@nagolinc
Copy link
Contributor Author

nagolinc commented Feb 22, 2021

I think I did the squash right? My git-foo is not the best.

--edit
nope

--edit

Maybe now?

@TheJackiMonster TheJackiMonster merged commit 06aab9c into olivierkes:develop Feb 22, 2021
@TheJackiMonster
Copy link
Collaborator

Yes, it worked now. I have adjusted the context menu a bit to make it work consistently with spell checking together. I think I will abstract the context menu in a different file if the functionality grows even more. ^^'

@TheJackiMonster TheJackiMonster added this to the 0.12.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants