Fixed bugs caused by parallel access during multithreading #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the 'textEditView' should synchronize model and text thread safe without problems.
Replaced attribute '_updating' by a QMutex
I just replaced the boolean with a QMutex for accurate synchronization.
TheJackiMonster
changed the title
Now the code is thread-safe as it should be but the original problem still occurs.
|
Thanks @TheJackiMonster for contributing a bug fix. There appear to be several commits in this pull request. Is this a work-in-progress or is this patch complete? If it is complete then it would help us if you rebase this merge request on the current develop branch, and also squash all the commits into one. Then when we have time we can review this PR. |
|
Yes, it should be complete. I will do that as soon as possible. ^^ |
Now the 'textEditView' should synchronize model and text thread safe without problems.
I just replaced the boolean with a QMutex for accurate synchronization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the 'textEditView' should synchronize model and text thread safe without problems. The QMutex solves the causes of parallel access. I guess most people haven't got any problems because it is so rare. If I find similar pieces of code I will probably add Mutexes too.
Keep up the good work on this project!
Also here is some information I looked up to get the implementation right:
https://doc.qt.io/qtforpython/PySide2/QtCore/QMutex.html