Added char-count with settings to enable/disable it. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry btw for the commit-arrangement in this. First I tried to make it only one commit but then I thought it would be better to include/merge the old commits from the original PR somehow. Still works as intended by me. |
|
This should fully solve #725 since the whitespace gets counted. |
|
I've added a setting for disabling counting the space characters. So it should solve the problem mentioned in #607. But because it would require to recount characters for all files and folders after changing the setting which is quite complicated to implement properly. It will require a restart of the application to work properly and update the amounts. But this shouldn't be a bigger deal for now. |
This was
linked to
issues
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen an old PR (#339) which should fix that issue and I adapted the changes from it. So this request will add a char-count next to the word-count or only via tooltip (default) depending on the general settings. There are also added settings to show the amount of chars in the tree-view.
This PR fixes #334 but it does count chars with whitespace. It is mentioned in other issues that whitespace should not be counted, so these will probably stay open until a setting for it is added.