Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling/Disabling POV for a specific character #748

Merged
merged 2 commits into from Feb 19, 2021
Merged

Enabling/Disabling POV for a specific character #748

merged 2 commits into from Feb 19, 2021

Conversation

TheJackiMonster
Copy link
Collaborator

I added a property to the characters to disable them for getting listed in selecting a POV. It can only be disabled if there aren't any elements in the plot which use the characters' POV. It uses a custom QSortFilterProxyModel to filter the actual model of characters.
This should fix the issue #335 completely.

@obw
Copy link
Contributor

obw commented Mar 31, 2020

Good Idea, but for me it's more work, because everyone can become POV...

I will see I test this Version, a searchable Selectbox, would be my dream solution for this...

But also, thanks for your efforts...

@TheJackiMonster
Copy link
Collaborator Author

@obw There are some other PRs at the moment with a global search and search & replace. So maybe some of their work can be adapted to implement something like this without creating too much duplicated code.
But yes, you are right this current state doesn't help you much with many POVs. I have a story with around 40 different POVs too. ^^'

@TheJackiMonster TheJackiMonster changed the title Optional pov Enabling/Disabling POV for a specific character Mar 31, 2020
@TheJackiMonster TheJackiMonster merged commit e18944e into olivierkes:develop Feb 19, 2021
@TheJackiMonster TheJackiMonster deleted the optional-pov branch February 19, 2021 15:08
@TheJackiMonster TheJackiMonster added this to the 0.12.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants