Clones importance setting when adding new characters. #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on Book of Acts sample project in English, French, and Italian. |
|
If you squash the commits to one, I would merge this. It should improve usability a little. |
BentleyJOakes
force-pushed
the
clone_importance
branch
from
e4e2b0f
to
bcb6956
Compare
When creating a new character, sets an appropriate importance level. * If a character is selected, the new character has the same importance level. * If a top-level importance level is selected, the new character has that level * Otherwise, the importance level is zero
BentleyJOakes
force-pushed
the
clone_importance
branch
from
bcb6956
to
06e35cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new character, sets an appropriate importance level.
Partially addresses #739