Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a test for ParseMMDFile function. #831

Merged
merged 4 commits into from Jun 8, 2022

Conversation

zeth
Copy link
Contributor

@zeth zeth commented Feb 2, 2021

I wrote tests to give full coverage for a single function. I thought I should submit it before writing a load more, find out how you like them to be done. :)

@siliconserf
Copy link
Contributor

I just pinged Oliver as to whether he is no longer running this project, or even still breathing. Hoping he's just busy.

@TheJackiMonster
Copy link
Collaborator

If you squash the commits to one, I will merge it.

@siliconserf
Copy link
Contributor

siliconserf commented Apr 8, 2021 via email

@TheJackiMonster
Copy link
Collaborator

Squashing commits is not really something Github specific. It's basically combining multiple commits into one which makes it easier maintaining a project because you don't have as much commits to select if something critical has to be reverted or something has to be looked up afterwards.

Here's a guide to squasing commits for example: https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec

It's basically using the rebase functionality of git. So you can create a commit with all changes regarding an older commit (for example the first commit of your PR) replacing those separate commits. Rebasing is also useful to make your old commits branching from the current state instead of the old state when you started a PR. So you don't have to merge multiple times creating crossings in the git graph.

@TheJackiMonster TheJackiMonster merged commit 692995f into olivierkes:develop Jun 8, 2022
@TheJackiMonster TheJackiMonster added this to the 0.14.0 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants