Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly disconnect add person connection. #834

Merged
merged 1 commit into from Feb 22, 2021

Conversation

BentleyJOakes
Copy link
Contributor

When disconnecting, properly unhook the connection changed in previous commit.

Should fix #833

@TheJackiMonster
Copy link
Collaborator

I think line 955 should also be added in this hacky try & catch block... ^^'
self.btnAddPerso.clicked.connect(self.lstCharacters.addCharacter, F.AUC)

Actually seeing this code makes me want to address it properly but it should be fine then.

@TheJackiMonster TheJackiMonster merged commit 4e6fa11 into olivierkes:develop Feb 22, 2021
@BentleyJOakes BentleyJOakes deleted the fix_crash branch February 22, 2021 20:32
@TheJackiMonster TheJackiMonster added this to the 0.12.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading another project leads to crash
2 participants