Fixed project not opening with missing background #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the quick way to patch this. I'd recommend changing the findFirstFile function in functions/__init__.py for a more permanent solution, but this should suffice for now.
|
Looks fine to me for now. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Issue #786 where Manuskript project files wouldn't open if the custom corkboard image was missing. The problem is that findFirstFile returns None if it doesn't find a file, so I added a check to see if the image was None to prevent it from trying to open a resource which doesn't exist. This is the quick way to patch this. I'd recommend changing the findFirstFile function in functions/init.py for a more permanent solution, but I don't know the knock-on effects of that, so this should suffice for now. Another suggestion could be to bundle custom image resources in the project file. Or, throw in some error handling.