Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the tests for travis-CI #858

Merged
merged 1 commit into from Apr 10, 2021

Conversation

belug23
Copy link
Contributor

@belug23 belug23 commented Apr 9, 2021

As mentioned in #857 there are tests in the project, but they've been failing for a while. This is the first step into fixing them. This is fixing the Linux part.

That PR fixes:

  • 2 warnings with the deprecation of the imp module
  • An error while splitting text caused by a self._model that is None
  • An error with the test trying to set a Model to an invalid value

@belug23
Copy link
Contributor Author

belug23 commented Apr 9, 2021

@TheJackiMonster TheJackiMonster merged commit 4e5809e into olivierkes:develop Apr 10, 2021
@TheJackiMonster TheJackiMonster added this to the 0.12.0 milestone Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants