Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 860 languagetool get locale language #861

Conversation

belug23
Copy link
Contributor

@belug23 belug23 commented Apr 11, 2021

This is a fix for #860
Another difference between language_check and language_tool_python can cause a crash when starting Manuskript after installing language_tool_python in a fresh python setup.
The tools have a different emplacement for the function get_locale_language. I've applied the same kind of fix that was done for other differences.

@belug23
Copy link
Contributor Author

belug23 commented Apr 11, 2021

Oops I didn't realise that I have test commit in that branch, I'll fix that give me a few minutes.

@belug23 belug23 force-pushed the fix_860_languagetool_get_locale_language branch from 9d5c16d to b72098d Compare April 11, 2021 11:40
@belug23
Copy link
Contributor Author

belug23 commented Apr 11, 2021

Ok now my mistake is fixed. Sorry for that.

@TheJackiMonster TheJackiMonster merged commit 4107c48 into olivierkes:develop Apr 11, 2021
@TheJackiMonster TheJackiMonster linked an issue Apr 11, 2021 that may be closed by this pull request
@TheJackiMonster TheJackiMonster added this to the 0.12.0 milestone Apr 11, 2021
@TheJackiMonster
Copy link
Collaborator

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small bug with LanguageTool
2 participants