Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add german translations for version 1.1.0 #537

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Add german translations for version 1.1.0 #537

merged 4 commits into from
Mar 8, 2023

Conversation

holistic-developer
Copy link
Contributor

No description provided.

@holistic-developer holistic-developer mentioned this pull request Mar 8, 2023
Open
@holistic-developer
Copy link
Contributor Author

@Art4 Could you review this, since you did version 1.0.0 as well?

Art4
Art4 suggested changes Mar 8, 2023
View reviewed changes
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
Art4
Art4 suggested changes Mar 8, 2023
View reviewed changes
source/de/1.1.0/index.html.haml Outdated Show resolved Hide resolved
source/de/1.2.0/index.html.haml Outdated Show resolved Hide resolved
@Art4
Copy link
Contributor

Art4 commented Mar 8, 2023 •
edited
Loading

Can someone please tell me where I can find the original text for version 1.2.0?

Update: Found it in #370.

@holistic-developer
Copy link
Contributor Author

holistic-developer commented Mar 8, 2023 •
edited
Loading

Thanks a lot for the great review, @Art4!
The original text for version 1.2.0 can be found here
11876fd which is part of this PR

I could also remove version 1.2.0 from this PR again and move it into a separate one to be merged when the English version is merged.

@Art4
Copy link
Contributor

Art4 commented Mar 8, 2023

I would appreciate a separate PR for 1.2.0.

@holistic-developer holistic-developer changed the title Add german translations forf both 1.1.0 and 1.2.0 Add german translations for version 1.1.0 Mar 8, 2023
@olivierlacan
Copy link
Owner

Can someone please tell me where I can find the original text for version 1.2.0?

There's no original text yet since 1.2.0 doesn't exist as a draft version yet but let me get that ready for the follow-up PR.

@olivierlacan olivierlacan merged commit b81d2d7 into olivierlacan:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Art4 Art4 Art4 approved these changes

@Bbjj88h Bbjj88h Bbjj88h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holistic-developer @Art4 @olivierlacan @Bbjj88h