Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is using deprecated supported features values which will be removed in HA Core 2025.1 #661

Closed
hartmood opened this issue Jan 2, 2024 · 15 comments

Comments

@hartmood
Copy link

hartmood commented Jan 2, 2024

https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

@ollo69
Copy link
Owner

ollo69 commented Jan 3, 2024

This is a new deprecation just introduced in 2024.1. To maintain compatibility with previous HA version, I cannot apply this change now. I will wait a couple of new HA version.

@hartmood
Copy link
Author

hartmood commented Jan 5, 2024

All good, just wanted to let you know. Thanks for making your plugin public.

@hartmood hartmood closed this as completed Jan 5, 2024
@ollo69
Copy link
Owner

ollo69 commented Jan 6, 2024

@hartmood,

sorry but I do not understand if you are just informing about deprecation or you receive a specific alert.
I think that I already removed this constant some times ago but may be I miss someone.

Thanks,

@ollo69 ollo69 reopened this Jan 6, 2024
@hartmood
Copy link
Author

hartmood commented Jan 8, 2024

I found the error message in my logfile using log viewer and thought it would be helpful for the developer to know.

@ollo69
Copy link
Owner

ollo69 commented Jan 8, 2024

Yes, thanks, but my question is if error message was related to this integration and in case if you can provide details, just because I thought that I already updated all reference but maybe I forgot someone.

Thanks.👍

@hartmood
Copy link
Author

hartmood commented Jan 8, 2024

I can confirm that I found the error message in my log file a few minutes before posting. And I can confirm I last saw the message a few days ago.

@ollo69
Copy link
Owner

ollo69 commented Jan 8, 2024

Ok, can you provide detail about the message?

@hartmood
Copy link
Author

hartmood commented Jan 8, 2024

"Plugin is using deprecated supported features values which will be removed in HA Core 2025.1" was the error message. Sorry, I gave very little background information.

@ollo69
Copy link
Owner

ollo69 commented Jan 8, 2024

Ok, could you please provide details about your LG device so I have an idea about what I should search? Thanks.

@hartmood
Copy link
Author

hartmood commented Jan 8, 2024

:-) - I am sorry:
Device Information
2RES1VE61PFWA-SxS (REFRIGERATOR)
from LG
Firmware: QC_Modem_1.2.80

@ollo69
Copy link
Owner

ollo69 commented Jan 8, 2024

Sorry, but are you running last integration version?

@hartmood
Copy link
Author

hartmood commented Jan 8, 2024

I have no update pending, so I should be on v0.36.2. Let me know where I can explicitly check the installed version in case.

@ollo69
Copy link
Owner

ollo69 commented Jan 8, 2024

This should be reported in the log during startup, but if you are sure about the version is ok. It is strange because I also have a refrigerator and I don't have any message, anyway I will deeply check.

@ollo69
Copy link
Owner

ollo69 commented Feb 5, 2024

Ok, I found the issue due to some specific device status where supported_feature was returning 0.
Will be fixed on next release.

@ollo69 ollo69 closed this as completed Feb 5, 2024
@hartmood
Copy link
Author

hartmood commented Feb 5, 2024

Wow. Well done. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants