Preserve filename extensions to prevent AtomicParsley from segfaulting.

olly · Jun 1, 2011 · 498ad0a · 498ad0a
1 parent 8939b6c
commit 498ad0a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/AtomicTV.rb b/lib/AtomicTV.rb
@@ -1,6 +1,7 @@
+require 'fileutils'
 require 'open-uri'
 require 'pathname'
-require 'tempfile'
+require 'tmpdir'
 
 require 'plist'
 require 'tvdb_party'

diff --git a/lib/AtomicTV/episode_metadata.rb b/lib/AtomicTV/episode_metadata.rb
@@ -80,9 +80,11 @@ def writers
     attr_reader :posters
 
     def with_loaded_posters
+      temporary_directory = Dir.mktmpdir
+
       @posters = series.season_posters(episode.season_number, 'en').map do |poster|
         url = ArtworkBaseURL + poster.path
-        file = Tempfile.new('AtomicTV')
+        file = File.new(File.join(temporary_directory, File.basename(url)), 'w')
         file.write(open(url).read)
         file.close
         file
@@ -91,7 +93,7 @@ def with_loaded_posters
       yield
 
     ensure
-      @posters.each {|file| file.unlink}
+      FileUtils.rm_rf(temporary_directory)
       @posters = nil
     end