Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1858: Cannot issue stock in EMR #45

Closed
ianwilson156 opened this issue Jan 14, 2023 · 1 comment
Closed

1858: Cannot issue stock in EMR #45

ianwilson156 opened this issue Jan 14, 2023 · 1 comment
Assignees
@ollybh
Labels
1858 Affects the 1858 implementation bug Something isn't working

Comments

@ianwilson156
Copy link

ZPB is at a share value of 50 without a train and little cash. The owner has lots of cash and there are 5 shares available to issue for Emergency Money Raising.

But when I try to issue some stock, I get an error message: "must buy train from the depot after issuing shares". What should happen is that the company closes.

Hotseat game, so I'll send you the JSON in an email.

Contributing just cash from hand works correctly. Also, skipping buying a train closes the company correctly, except that it is no longer available to start in the next SR (which it should be).
@ianwilson156 ianwilson156 mentioned this issue Jan 15, 2023
Closed
@ollybh ollybh self-assigned this Jan 15, 2023
@ollybh ollybh added bug Something isn't working 1858 Affects the 1858 implementation labels Jan 15, 2023
@ollybh
Copy link
Owner

ollybh commented Jan 15, 2023

Fixed by commits 838bc36 (error when issuing shares) and 9e45a15 (corporation could not be restarted).

@ollybh ollybh closed this as completed Jan 15, 2023
ollybh added a commit that referenced this issue Jan 15, 2023
@ollybh
[1858] Closed corporations are available to be restarted
9e45a15 
Fixes part of issue #45.
ollybh added a commit that referenced this issue Jan 15, 2023
@ollybh
[1858] Fix error if corporation closes due to EMR
838bc36 
The check to make sure a corporation buys a train after issuing shares
during emergency raising was not coping with a corporation closing if
enough shares are issued for it to hit the bottom of the stock market.
Check if this has happened and don't throw an error in this case.

Fixes the rest of issue #45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollybh ollybh

Labels
1858 Affects the 1858 implementation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ollybh @ianwilson156