Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number.prototype methods #4

Closed
ollym opened this issue Aug 29, 2011 · 1 comment
Closed

Number.prototype methods #4

ollym opened this issue Aug 29, 2011 · 1 comment
Assignees
@ollym
Labels
api feature
Milestone
1.1.0

Comments

@ollym
Copy link
Owner

ollym commented Aug 29, 2011

With inspiration from Ruby:

ceil() / floor()
round(precision)
lcm(_int) / gcd(_int)
isOdd() / isEven()
times() / upto() / downto()
chr()
next() / prev()
@ghost ghost assigned ollym Aug 29, 2011
ollym pushed a commit that referenced this issue Aug 29, 2011
Added Number.prototype.gcd. Ref #4
9819a4e 
An implementation of Stein's binary algorithm. Often faster than
Euclidean's.
ollym pushed a commit that referenced this issue Aug 29, 2011
Added Number.prototype.lcm. Ref #4
602d6de
ollym pushed a commit that referenced this issue Aug 29, 2011
Added Number.[ceil,floor,char,abs]. Ref #4
4d00da9 
These just alias other methods so no real need for tests.
ollym pushed a commit that referenced this issue Aug 29, 2011
Fixed gcd and lcm. Added Number.prototype.round. Ref #4
b7d785a 
Long story - was using wrong tests which gave a false positive!
ollym pushed a commit that referenced this issue Aug 29, 2011
Made Number.prototype.[chr,even,odd] getters. Ref #4
ede890a 
This makes a lot more sense to me. Any opinions?
@ollym
Copy link
Owner Author

ollym commented Aug 29, 2011

I've decided against times / upto / downto for now. May change this in the future but not for this milestone.

@ollym ollym closed this as completed Aug 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollym ollym

Labels
api feature
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@ollym