Refactor and fix class method generate_cjk
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor method with the intent of making it easier to understand. The method is now shorter (6 LoC instead of 12) and has more descriptive variable names. Also fix a minor bug. Formerly, the method would never return the character with codepoint 0x9FCC, which is at the upper limit of the CJK character set.
Use `random.randint` instead of `random.randrange`. The former returns a number N where `a <= N <= b`.
Add method `generate_utf8`, which returns a string composed randomly from the entire set of UTF-8 characters. Update method `generate_string` so that it calls `generate_utf8` and `generate_cjk` when asked for a "utf8" or "cjk" string, respectively. Update docstring for method `generate_string` to reflect these changes.
|
ACK and Roll |
omaciel
added a commit
that referenced
this pull request
May 17, 2014
Refactor and fix class method `generate_cjk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor method with the intent of making it easier to understand. The method is
now shorter (6 LoC instead of 12) and has more descriptive variable names.
Also fix a minor bug. Formerly, the method would never return the character with
codepoint 0x9FCC, which is at the upper limit of the CJK character set.