Added support for generating html chars #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[kedar@localhost fauxfactory]$ python
|
|
|
||
| html_tag = random.choice(HTML_TAGS).lower() | ||
| output_string = u'<%s>%s</%s>' % ( | ||
| html_tag, cls.generate_string("alpha", length), html_tag) |
There was a problem hiding this comment.
Please use format for string interpolation, not %.
|
If the parameter |
|
ok, fixing as per comments. |
|
Great. Thank you. |
kbidarkar
force-pushed
the
add-html-support
branch
2 times, most recently
from
dc458e9
to
d33be10
Compare
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| from collections import Iterable | |||
| from fauxfactory.constants import ( | |||
| LOREM_IPSUM_TEXT, | |||
| LOREM_IPSUM_TEXT, HTML_TAGS, | |||
There was a problem hiding this comment.
Minor thing, but alphabetical ordering is preferred.
kbidarkar
force-pushed
the
add-html-support
branch
from
d33be10
to
ca59617
Compare
kbidarkar
force-pushed
the
add-html-support
branch
from
ca59617
to
3f9e56e
Compare
Added test for generate_html function
|
ACK.
|
|
ACK and thanks for the test too @kbidarkar :) |
omaciel
added a commit
that referenced
this pull request
Sep 17, 2014
Added support for generating html chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.