Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not instantiate FauxFactory #39

Merged
merged 1 commit into from
Sep 18, 2014
Merged

Do not instantiate FauxFactory #39

merged 1 commit into from
Sep 18, 2014

Conversation

Ichimonji10
Copy link
Contributor

All methods on FauxFactory are class methods. Do not instantiate FauxFactory
when running unit tests.

@Ichimonji10
Do not instantiate FauxFactory
127c582 
All methods on FauxFactory are class methods. Do not instantiate FauxFactory
when running unit tests.
@Ichimonji10
Copy link
Contributor Author 

[ichimonji10@beech:fauxfactory]$ make test
python -m unittest discover --start-directory tests --top-level-directory .
..........................................................................................................................................................
----------------------------------------------------------------------
Ran 154 tests in 0.377s

OK

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 127c582 on Ichimonji10:classmethod into 0f9d8ce on omaciel:master.

@omaciel
Copy link
Owner

omaciel commented Sep 18, 2014

ACK

omaciel added a commit that referenced this pull request Sep 18, 2014
@omaciel
Merge pull request #39 from Ichimonji10/classmethod
3927cd9 
Do not instantiate FauxFactory
@omaciel omaciel merged commit 3927cd9 into omaciel:master Sep 18, 2014
@Ichimonji10 Ichimonji10 deleted the classmethod branch September 18, 2014 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ichimonji10 @coveralls @omaciel