Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError for gen_string function. #46

Merged
merged 1 commit into from
Sep 23, 2014
Merged

Raise ValueError for gen_string function. #46

merged 1 commit into from
Sep 23, 2014

Conversation

omaciel
Copy link
Owner

@omaciel omaciel commented Sep 23, 2014

If an invalid string type is requested from gen_string, raise
ValueError instead of a generic Exception. Fixes issue #30.

If an invalid string type is requested from ``gen_string``, raise
``ValueError`` instead of a generic ``Exception``. Fixes issue #30.
@elyezer
Copy link
Contributor

elyezer commented Sep 23, 2014

ACK

@Ichimonji10
Copy link
Contributor

APT

omaciel added a commit that referenced this pull request Sep 23, 2014
Raise ``ValueError`` for ``gen_string`` function.
@omaciel omaciel merged commit 7d272aa into master Sep 23, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 695ea70 on fix-issue-30 into d54c8c8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 695ea70 on fix-issue-30 into d54c8c8 on master.

@omaciel omaciel deleted the fix-issue-30 branch September 24, 2014 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants