Add random.seed call before every random usage #81

elyezer · 2016-01-12T19:14:24Z

Make sure to regenerate the seed every time before calling a random
function. This will make sure to generate different values even when
running on a multi-process testing environment like py.test using the
pytest-xdist plugin.

Make sure to regenerate the seed every time before calling a random function. This will make sure to generate different values even when running on a multi-process testing environment like py.test using the pytest-xdist plugin.

elyezer · 2016-01-12T19:16:28Z

Check the captured stdout for the generated value.

The result below was run against the following test file:

import unittest

from fauxfactory import gen_alphanumeric


class TestCase(unittest.TestCase):
    def test_1(self):
        print(gen_alphanumeric())
        self.fail()

    def test_2(self):
        print(gen_alphanumeric())
        self.fail()

Without the changes running on a single process mode:

$ py.test test.py       
================================ test session starts ================================
platform linux -- Python 3.4.2, pytest-2.8.2, py-1.4.30, pluggy-0.3.1
rootdir: /home/elyezer/code/robottelo, inifile: 
plugins: xdist-1.13.1, cov-2.2.0
collected 2 items 

test.py FF

===================================== FAILURES ======================================
__________________________________ TestCase.test_1 __________________________________

self = <test.TestCase testMethod=test_1>

    def test_1(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:9: AssertionError
------------------------------- Captured stdout call --------------------------------
yTJmFRkBk8
__________________________________ TestCase.test_2 __________________________________

self = <test.TestCase testMethod=test_2>

    def test_2(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:13: AssertionError
------------------------------- Captured stdout call --------------------------------
ld1Ar8wRw3
============================= 2 failed in 1.00 seconds ==============================

Without the changes running on a multi-process mode:

py.test -s -v -n auto --boxed --cache-clear test.py
================================ test session starts ================================
platform linux -- Python 3.4.2, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 -- /home/elyezer/.virtualenvs/robottelo/bin/python3
cachedir: .cache
rootdir: /home/elyezer/code/robottelo, inifile: 
plugins: xdist-1.13.1, cov-2.2.0
[gw0] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw1] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw2] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw3] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw0] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw1] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw3] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw2] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
gw0 [2] / gw1 [2] / gw2 [2] / gw3 [2]
scheduling tests via LoadScheduling
[gw0] FAILED test.py::TestCase::test_1 
[gw0] FAILED test.py::TestCase::test_2 

===================================== FAILURES ======================================
__________________________________ TestCase.test_1 __________________________________
[gw0] linux -- Python 3.4.2 /home/elyezer/.virtualenvs/robottelo/bin/python3
self = <test.TestCase testMethod=test_1>

    def test_1(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:9: AssertionError
------------------------------- Captured stdout call --------------------------------
0fUWTQe18P
__________________________________ TestCase.test_2 __________________________________
[gw0] linux -- Python 3.4.2 /home/elyezer/.virtualenvs/robottelo/bin/python3
self = <test.TestCase testMethod=test_2>

    def test_2(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:13: AssertionError
------------------------------- Captured stdout call --------------------------------
0fUWTQe18P
============================= 2 failed in 4.22 seconds ==============================

After the changes running on multi-process mode:

py.test -s -v -n auto --boxed test.py              
================================ test session starts ================================
platform linux -- Python 3.4.2, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 -- /home/elyezer/.virtualenvs/robottelo/bin/python3
cachedir: .cache
rootdir: /home/elyezer/code/robottelo, inifile: 
plugins: xdist-1.13.1, cov-2.2.0
[gw0] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw1] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw2] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw3] linux Python 3.4.2 cwd: /home/elyezer/code/robottelo
[gw0] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw1] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw2] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
[gw3] Python 3.4.2 (default, Jul  9 2015, 17:24:30)  -- [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)]
gw0 [2] / gw1 [2] / gw2 [2] / gw3 [2]
scheduling tests via LoadScheduling
[gw2] FAILED test.py::TestCase::test_1 
[gw2] FAILED test.py::TestCase::test_2 

===================================== FAILURES ======================================
__________________________________ TestCase.test_1 __________________________________
[gw2] linux -- Python 3.4.2 /home/elyezer/.virtualenvs/robottelo/bin/python3
self = <test.TestCase testMethod=test_1>

    def test_1(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:9: AssertionError
------------------------------- Captured stdout call --------------------------------
5eBetOyxGv
__________________________________ TestCase.test_2 __________________________________
[gw2] linux -- Python 3.4.2 /home/elyezer/.virtualenvs/robottelo/bin/python3
self = <test.TestCase testMethod=test_2>

    def test_2(self):
        print(gen_alphanumeric())
>       self.fail()
E       AssertionError: None

test.py:13: AssertionError
------------------------------- Captured stdout call --------------------------------
5WG86PBIEZ
============================= 2 failed in 4.03 seconds ==============================

omaciel · 2016-01-12T19:28:04Z

APT

Also remove pylint check from travis since there is an issue with Python 2.6.

Add random.seed call before every random usage

I changed the random selection of some methods from comprehensions to uses of random.choices. Most improved by around 15%. However, gen_cjk saw a 5.5x speedup! I then took it a bit further by moving random.seed out of each method call and into the module scope. This greatly improved the runtime of each changed method. Additionally, it should still alleviate the original concern solved with omaciel#81

I changed the random selection of some methods from comprehensions to uses of random.choices. Most improved by around 15%. However, gen_cjk saw a 5.5x speedup! I then took it a bit further by moving random.seed out of each method call and into the module scope. This greatly improved the runtime of each changed method. Additionally, it should still alleviate the original concern solved with #81

Add random.seed call before every random usage

ecb03f5

Make sure to regenerate the seed every time before calling a random function. This will make sure to generate different values even when running on a multi-process testing environment like py.test using the pytest-xdist plugin.

Make pylint happy about import order

b4c370b

Also remove pylint check from travis since there is an issue with Python 2.6.

elyezer force-pushed the random-seed branch from 97e20b7 to b4c370b Compare January 12, 2016 19:36

omaciel added a commit that referenced this pull request Jan 12, 2016

Merge pull request #81 from elyezer/random-seed

1bb9e70

Add random.seed call before every random usage

omaciel merged commit 1bb9e70 into omaciel:master Jan 12, 2016

elyezer deleted the random-seed branch January 13, 2016 10:09

JacobCallahan mentioned this pull request Aug 27, 2022

Improve execution time of some key methods #123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add random.seed call before every random usage #81

Add random.seed call before every random usage #81

elyezer commented Jan 12, 2016

elyezer commented Jan 12, 2016

omaciel commented Jan 12, 2016

Add random.seed call before every random usage #81

Add random.seed call before every random usage #81

Conversation

elyezer commented Jan 12, 2016

elyezer commented Jan 12, 2016

omaciel commented Jan 12, 2016