Added validator, tries and default to str generator functions #87
Conversation
renzon
changed the title
|
@omaciel I've tried to access coverals to check why coverage decrease but faced this msg: The owner of this repo needs to re-authorize with github; their OAuth credentials are no longer valid so the file cannot be pulled from the github API |
|
|
||
| class CheckValidationTestCase(unittest.TestCase): | ||
| """_check_validation decorator tests""" | ||
|
|
There was a problem hiding this comment.
We should add a real case test here:
Example is SatelliteQE/robottelo#4407 which generated string cannot start with number
And also https://github.com/SatelliteQE/robottelo/blob/master/robottelo/libvirt_discovery.py#L21 which gen_mac cannot start with fe:
(then once released we can update those codes to use validators)
There was a problem hiding this comment.
I didn't add validation to gen_mac, going to do that
fauxfactory/__init__.py
Outdated
| if validator is None: | ||
| validator_fcn = lambda _: True | ||
| else: | ||
| validator_fcn=validator |
There was a problem hiding this comment.
missing whitespace between operator
| # Public Functions ------------------------------------------------------------ | ||
|
|
||
|
|
||
| def gen_string(str_type, length=None): | ||
| def gen_string(str_type, length=None, validator=None, default=None, tries=10): |
There was a problem hiding this comment.
Once this function only delegates to already decorated functions, decorating it would only useless apply validation 2 times.
|
@omaciel can we merge this one? (and release) |
|
@rochacbruno merged and published on Pypi! @renzon it would be great to have the documentation updated to include some examples of how to use the new functionality :) |
close #86