avoid updating om.next/queries unnecessarily when unmounting #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a performance-sensitive component that renders a large list of items, and it only shows a subset of items in the actual DOM to fill the view. This subset is updated as you scroll to make it appear that everything is loaded in the DOM, when it's actually not.
I noticed that when items outside the view are removed from the DOM (after scrolling), a
reconcile!
and rerender would happen. This happens because the state was being modified incomponentWillUnmount
, but we don't need to modify that state ifom.next/queries
does not have the component instance in it. This optimization avoids unnecessary rerenders, and more importantly unnecessary query execution (modifying the state triggers both).