Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_facts may contain firewalld or firewalld.service #3

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

manics
Copy link
Member

@manics manics commented Apr 22, 2020

Bug-fix, tag 0.3.1

@joshmoore
Copy link
Member

Think Travis status is spurious. Change seems ok enough.

@manics manics closed this Apr 23, 2020
@manics manics reopened this Apr 23, 2020
@manics
Copy link
Member Author

manics commented Apr 23, 2020

@sbesson
Copy link
Member

sbesson commented Apr 23, 2020

Removed the unnecessary Travis CI branch additional check for merging this PR from the repo settings. Only the continuous-integration/travis-ci/pr check should be required.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmoore joshmoore merged commit 300c074 into ome:master Apr 24, 2020
@sbesson
Copy link
Member

sbesson commented Apr 24, 2020

For a still unclear reason, it got a notification that the automatic role import triggered by Travis CI has failed. Re triggered the role import manually from the Galaxy UI and version 0.3.1 is now available from Galaxy - https://galaxy.ansible.com/ome/iptables_raw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants