Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream load balance servers #2

Merged
merged 2 commits into from
Jul 7, 2017
Merged

Conversation

manics
Copy link
Member

@manics manics commented Jun 22, 2017

Adds support for referencing a set of upstream servers instead of a single backend server: http://nginx.org/en/docs/http/load_balancing.html

New feature, tag 1.2.0

@joshmoore
Copy link
Member

Primary issue I see is that there aren't any tests. How feasible do you think they would be? (Not in the next week though)

@manics
Copy link
Member Author

manics commented Jun 22, 2017

Problem is this role has grown so there are too many options to test thoroughly.

@joshmoore
Copy link
Member

Hmmm.... but that leaves this getting more & more difficult to manage. What would be your plan? To split the role? (Are there other roles on galaxy that could supplement this one?)

@manics
Copy link
Member Author

manics commented Jun 23, 2017

I think this is a case where the IDR needs a lot of specific functionality from nginx which has to be configured in one go, whereas all our other uses are fairly simple (straight-forward proxying)- so maybe a simple role for general use and a seperate IDR one?

@joshmoore
Copy link
Member

Not sure. I can imagine wanting to balance 2 OMERO.webs on the open-source side quite soon.

@manics
Copy link
Member Author

manics commented Jun 23, 2017

We should scope this out properly then, since there have only been two use cases so far:

  • IDR
  • web-proxy

@manics
Copy link
Member Author

manics commented Jul 5, 2017

How should we proceed?

@joshmoore
Copy link
Member

I'm fine with getting this in now. My preference would be that we consider this the "one role to rule them all" and we find a way to add tests in the future.

@joshmoore joshmoore mentioned this pull request Jul 7, 2017
@joshmoore joshmoore merged commit 29fd54e into ome:master Jul 7, 2017
@manics manics deleted the upstream-balance branch July 7, 2017 16:24
@sbesson sbesson added this to the 1.2.0 milestone Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants