Replace single monitored log dir with separate server and web #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change
|
In general, makes sense. Are we currently not getting logs because of this? |
|
At the moment only the server logs are monitored https://github.com/IDR/deployment/blob/master/ansible/group_vars/omero-hosts.yml#L58 |
There are several TODOs, both due to ansible-lint and due to an unknown problem with the service stopping
|
I've updated travis. There's are several TODOs, but this is no worse than it was before. |
|
It might be the lack of a valid slack token that's causing a problem, I'll investigate |
|
@joshmoore I've taken the molecule test out of travis |
|
Once green, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openmicroscopy/ansible-role-omero-server/tree/2.0.0-m1 and https://github.com/openmicroscopy/ansible-role-omero-web/tree/1.0.0-m3 change the location of OMERO.server and OMERO.web. This PR replaces the single
omero_logmonitor_logs_dirparameter withomero_logmonitor_logs_dir_serverandomero_logmonitor_logs_dir_web, and changes the defaults to match the default locations for OMERO.server and OMERO.web.This is a breaking change which mostly affects the default configuration. Advanced configuration will be mostly unaffected.