Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review the publication #13

Merged
merged 2 commits into from Jan 11, 2024
Merged

review the publication #13

merged 2 commits into from Jan 11, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Jan 9, 2024

This PR modifies the publication workflow. It uses the command line directly since I have not found an action allowing us to specify the name since it was previously not ignored if declared in meta/main.yml. See https://github.com/ansible/galaxy/pull/2767/files

The role name is extracted from the meta/main.yml and specified as a command line argument.
If this approach works, changes should be added to https://github.com/ome/action-ansible-galaxy-publish (repository is currently read-only)

@jburel jburel requested a review from sbesson January 9, 2024 11:39
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://forum.ansible.com/t/ansible-galaxy-s-role-import-enhancements-and-fixes-for-the-new-year/3206/2 which describes a very similar issue.

The proposed change i.e. passing the role name via an option at the command-line is consistent which the workaround described by the Galaxy developers in https://forum.ansible.com/t/ansible-galaxy-s-role-import-enhancements-and-fixes-for-the-new-year/3206/3.

Reading the upstream code a bit, an possible alternative approach would be to rename this repository to avoid starting with ansible-role as this would prevent the auto-computed alternate_role_name from overriding role_name in the metadata. Is it worth following-up on the forum to ask for clarifications on the official behavior?

@jburel
Copy link
Member Author

jburel commented Jan 9, 2024

That is also an option.
I think we need to come to a general consensus.
The renaming of the repo avoid having to maintain an action since the current GHA will work

@jburel
Copy link
Member Author

jburel commented Jan 9, 2024

using --role-name seems to be the most suitable approach cf. reply on forum post

@jburel
Copy link
Member Author

jburel commented Jan 9, 2024

Change made to ome/action-ansible-galaxy-publish#1

@jburel jburel merged commit 007e093 into ome:master Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants