Fix Z and T size calculation for InCell 6000 data (rebased onto dev_5_0) #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--rebased-from #1212 |
|
Note: this PR will require |
|
Merged in |
|
Travis restarted |
|
Tested on octopus as user-1. .xdce file imports OK, has 16 fields, each field having 96 wells. Each well looks totally black (is that expected?) and has a single Z-slice. If the image contents is expected, this is good to merge. |
|
Images are expected to be all black, as we do not have the pixels files for this dataset. |
melissalinkert
added a commit
that referenced
this pull request
Jul 16, 2014
Fix Z and T size calculation for InCell 6000 data (rebased onto dev_5_0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as gh-1212 but rebased onto dev_5_0.
Fixes https://trac.openmicroscopy.org.uk/ome/ticket/12416. There is one .xdce file attached to the ticket which needs to be verified - there should be 96 wells with 16 fields per well and 1 Z section/timepoint. Without this change, multiple Z sections were detected. This is the only InCell 6000 dataset we have; I would not expect other datasets to be affected (so it's sufficient to verify that repository tests pass).
See as well https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=7545#p14250.