-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeiss CZI: fix dimension calculations when expected planes are missing (rebased onto dev_5_0) #1400
Zeiss CZI: fix dimension calculations when expected planes are missing (rebased onto dev_5_0) #1400
Conversation
This prevents blank planes from containing garbage data.
This prevents pixel data from being accidentally included on the companion file list.
--rebased-from #1386 |
Checked with image from ticket 12556, looks fine:
Unfortunately I couldn't figure out, what the expected result for the QA 10301 files should look like, handing over to someone else to review |
The showinf results for 141016_OP43adult_Worm3_DAPI_head.czi (QA 10301) match the results from the original PR's review, so I think, it's good to merge!
|
It doesn't look like |
I can't remove |
Zeiss CZI: fix dimension calculations when expected planes are missing (rebased onto dev_5_0)
From QA post: |
This is the same as gh-1386 but rebased onto dev_5_0.
This should fix http://trac.openmicroscopy.org.uk/ome/ticket/12556. The dimensions for the files in QA 9521 and 10301 should now match the expected dimensions listed in the ticket and QA issues. I would not expect this to cause any test failures.
/cc @emilroz