Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeiss CZI: fix series count for fused images #1725

Merged
merged 1 commit into from Apr 21, 2015

Conversation

melissalinkert
Copy link
Member

Fixes https://trac.openmicroscopy.org/ome/ticket/12789.

To test, use the two files referenced in the ticket (both have been uploaded to zeiss-czi/sebastian/fused). The *_fused.czi file would have shown 6 series of strange images without this change; with this change, there should be a single large image that more or less matches what is shown in Zen. The behavior when opening the *_stitched.czi file should be unchanged.

@sbesson
Copy link
Member

sbesson commented Apr 16, 2015

Import of the _fused.czi file into OMERO with this PR went fine resulting in one image as opposed to 6 without this PR. So the PR at least fixes the series mismatch issue. On the flip side, pyramid generation for the CZI file tested in the context of #1733 hangs and blocks pyramid generation for this file as well. This may be either an issue at the reader level or caused by the upstream ome/openmicroscopy#3713 PR touching pyramid logic. Still under investigation.

@sbesson
Copy link
Member

sbesson commented Apr 16, 2015

After completion of the pyramid for file mentioned in #1733, pyramid generation for the fused CZI, the pyramid for the fused CZI file was generated in 10 min

2015-04-16 18:37:04,597 INFO  [ ome.services.pixeldata.PixelDataHandler] (2-thread-2) HANDLED EventLog:3907902(entityId=28526) [680826 ms.]

and the data visualization looks good:

screen shot 2015-04-16 at 19 01 32
screen shot 2015-04-16 at 19 01 51

Barring concerns about #1733, this PR looks ready to merge.

melissalinkert added a commit that referenced this pull request Apr 21, 2015
Zeiss CZI: fix series count for fused images
@melissalinkert melissalinkert merged commit cc5978f into ome:develop Apr 21, 2015
@melissalinkert
Copy link
Member Author

--no-rebase

@joshmoore joshmoore added this to the 5.1.1 milestone Apr 23, 2015
@melissalinkert melissalinkert deleted the 12789 branch January 28, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants