SimplePCI: fix Z position handling #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…excluded Fixes ome#4133. As noted there, .cxd files produced by newer versions of HCImage include both a "Position_Z" and "Position_Z_Fine" value. This can result in the "uniqueZ" list being larger than the number of detected planes. That causes line 381 to set sizeT to 0, which means that the following "while" loop runs until sizeZ and sizeT overflow to negative values. This intentionally does not check that the name equals "Position_Z", as some older files add a prefix to this name.
Sometimes the stream name will have a bunch of whitespace appended. This doesn't affect the stream path that is used to actually retrieve metadata values.
sbesson
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
The proposed change is sensible and fixes the initial of the sample file linked from the companion issue without introducing regressing on other SimplePCI samples.
Interestingly, I noticed that the reader does not set PlanePositionZ currently. This could be a follow-up RFE since this metadata is parsed anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4133.
See the commit message for 2f778ba in particular. Without this change,
showinfon one of the files in #4133 will succeed and one will fail. With this change, both files should be readable.