ZeissZVIReader: Fix detection of label string offset #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a 2 byte pad between the end of the ShapeAttrs block and the start of the Label string. And the string may or may not be null, making it difficult to detect reliably. We allow for a fuzzy match at 0 or 2 bytes after the end of the ShapeAttrs. This padding is typically only found in the initial Shape, and missing in subsequent shapes.
| } | ||
|
|
||
| if (nshape.text != null) | ||
| LOGGER.debug(" Text=" + nshape.text); |
There was a problem hiding this comment.
Minor suggestion: LOGGER.debug(" Text={}", nshape.text) to not incur StringBuilder overhead when debugging is turned off.
Merged
|
--test zeiss-zvi |
|
Happy to merge if overnight builds are green. |
melissalinkert
added a commit
that referenced
this pull request
Apr 29, 2013
ZeissZVIReader: Fix detection of label string offset
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a 2 byte pad between the end of the ShapeAttrs
block and the start of the Label string. And the string
may or may not be null, making it difficult to detect
reliably. We allow for a fuzzy match at 0 or 2 bytes after
the end of the ShapeAttrs. This padding is typically
only found in the initial Shape, and missing in subsequent
shapes.