Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict ImageJ version to < 1.47o (rebased onto dev_4_4) #517

Merged

Conversation

melissalinkert
Copy link
Member

This is the same as gh-502 but rebased onto dev_4_4.


This prevents us from running into a bug in ImageStack introduced in
1.47o.

This prevents us from running into a bug in ImageStack introduced in
1.47o.
@jburel
Copy link
Member

jburel commented May 14, 2013

Changes look fine, travis is happy, We should probably introduce a similar limitation when insight is used as an imageJ plugin. We only check for the min version not the maximum version

@joshmoore
Copy link
Member

We'd have to be careful though. That particular bug was only present for 2 letter versions (o and p I think). If we hard-coded a maximum, we'd likely have to release updated plugins more often.

@jburel
Copy link
Member

jburel commented May 14, 2013

The value will be in the configuration file so that could be modified. With the list of things to do, this certainly has low priority. More like an open question

@joshmoore
Copy link
Member

@melissalinkert: 1.47q is not listed with a specific BF fix reference (http://rsbweb.nih.gov/ij/notes.html) Do we want to merge this and then can look at http://trac.openmicroscopy.org.uk/ome/ticket/10837 along with the discussion here?

@melissalinkert
Copy link
Member Author

Yes, let's merge this and then worry about 1.47q and http://trac.openmicroscopy.org.uk/ome/ticket/10837 in a separate PR.

joshmoore added a commit that referenced this pull request May 16, 2013
…rsion

Restrict ImageJ version to < 1.47o (rebased onto dev_4_4)
@joshmoore joshmoore merged commit 784611a into ome:dev_4_4 May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants