Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: markers on lines #18

Closed
mtbc opened this issue Feb 11, 2016 · 5 comments
Closed

model: markers on lines #18

mtbc opened this issue Feb 11, 2016 · 5 comments
Labels

Comments

@mtbc
Copy link
Member

mtbc commented Feb 11, 2016

The OME-XML schema at http://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2015-01/ROI_xsd.html has markerStart and markerEnd properties on lines. These are absent among OMERO's model objects but are clearly anticipated by https://github.com/openmicroscopy/openmicroscopy/blob/037f0caf/components/model/resources/mappings/roi.ome.xml#L70.

Should String-based markerStart and markerEnd properties be added to OMERO's Line and Polyline? Perhaps some other change would be better to bring the two schemas into line?

@mtbc mtbc changed the title markers on lines model: markers on lines Feb 11, 2016
@joshmoore
Copy link
Member

Not having an alternative proposal, I would think we unify by adding the markers to OMERO.

@will-moore
Copy link
Member

Enumerations for MarkerStart and MarkerEnd are

  • Arrow
  • Circle
  • Square

Any idea's how a Circle and Square are displayed on the end of a line? E.g are they centred at the x,y coordinate, or fit inside it (like the Arrow does in OMERO.figure)?

screen shot 2016-02-24 at 09 42 14

Do they have a fixed size?
In OMERO.figure, I try to make a suitable-sized Arrow based on the line width, so maybe the same approach would apply to Circle and Square?
Do we even have any need for Circle and Square? Maybe we should only support Arrow?

@joshmoore
Copy link
Member

The current list of Graffle supported arrow heads:

screen shot 2016-02-25 at 11 51 21

@mtbc
Copy link
Member Author

mtbc commented Feb 26, 2016

The current plan is to add markerStart and markerEnd to OMERO but to restrict OME-XML Marker to simply Arrow for the meantime.

mtbc added a commit to mtbc/bioformats that referenced this issue Mar 16, 2016
mtbc added a commit to mtbc/openmicroscopy that referenced this issue Mar 17, 2016
ome/design#18 (comment)

also cleans up related design discussion from 2009
@mtbc
Copy link
Member Author

mtbc commented Mar 17, 2016

@mtbc mtbc closed this as completed Mar 17, 2016
rgozim pushed a commit to rgozim/openmicroscopy that referenced this issue Oct 8, 2018
ome/design#18 (comment)

also cleans up related design discussion from 2009
joshmoore pushed a commit to ome/omero-model that referenced this issue Dec 11, 2018
ome/design#18 (comment)

also cleans up related design discussion from 2009
joshmoore pushed a commit to ome/omero-model that referenced this issue Dec 11, 2018
ome/design#18 (comment)

also cleans up related design discussion from 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants