Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink python_deps.sh and add paragraph in the caveats (see #10649) #25

Merged
merged 4 commits into from
Mar 15, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 11, 2013

Copy python_deps.sh to /usr/local/bin and add note to caveats.

When updating the formula for 4.4.7, we can remove the if (build.head? or build.devel)?

@sbesson
Copy link
Member Author

sbesson commented Mar 11, 2013

From OMERO-homebrew-develop#19

==> Caveats

For non-homebrew Python, you need to set your PYTHONPATH:
export PYTHONPATH=/usr/local/Cellar/omero/5.0.0-DEV/lib/python:$PYTHONPATH

To finish the installation, source python_deps.sh in your shell:
  source /usr/local/Cellar/omero/5.0.0-DEV/bin/python_deps.sh

==> Summary
      /usr/local/Cellar/omero/5.0.0-DEV: 5968 files, 166M, built in 13.3 minutes

@joshmoore
Copy link
Member

My vote would be to rename python_deps.sh to omero_python_deps. Also, does it need to be sourced or can it just be executed?

@sbesson
Copy link
Member Author

sbesson commented Mar 12, 2013

  • Should we rename the file in the main code or in the formula installation?
  • Execution should be enough

@joshmoore
Copy link
Member

When inside of the ome.git there's no reason to prefix with "omero_" so I'd say just rename in homebrew.

@sbesson
Copy link
Member Author

sbesson commented Mar 12, 2013

From OMERO-homebrew-stable#139

==> Checking out branch dev_4_4
==> ./build.py -Dice.home=/usr/local build-default
==> Linking zeroc libaries
==> Caveats

For non-homebrew Python, you need to set your PYTHONPATH:
export PYTHONPATH=/usr/local/Cellar/omero/HEAD/lib/python:$PYTHONPATH

To finish the installation, source or execute omero_python_deps in your
shell:
  source /usr/local/Cellar/omero/HEAD/bin/omero_python_deps

==> Summary
üç∫  /usr/local/Cellar/omero/HEAD: 5920 files, 184M, built in 13.6 minutes

@joshmoore
Copy link
Member

My only nitpick is that I'm concerned that the script if sourced will execute the current shell. Would you be willing to remove the source or wording?

@joshmoore
Copy link
Member

There was a minor issue with brew install sbesson/alt/omero caused by much older formulae zeroc-ice33 and berkeley-db46. Uninstalling both of them fixed the issue.

Otherwise, location and naming of script seem fine:

sbesson-alt moore$ which omero_python_deps
/usr/local/bin/omero_python_deps
sbesson-alt moore$ omero_python_deps
/usr/local/bin/omero_python_deps: line 26: bin/pip: No such file or directory
pip 1.0.2 from /usr/local/lib/python2.6/site-packages/pip-1.0.2-py2.6.egg (python 2.6)
Using existing pip installed in /usr/local

Two comments which may be for another PR:

  • The check for bin/pip is no longer really appropriate in this context.
  • The use of git for pytables causes a re-install even if already present. We might need to reconsider this.

Thoughts?

@sbesson
Copy link
Member Author

sbesson commented Mar 14, 2013

@joshmoore: both comments are valid but need to be fixed in a openmicroscopy PR.

  • re bin/pip: unless you move to /usr/local first, this is true. Would you check for pip only?
  • re pytables, I have no idea why we use the git instead of pip install tables. Is it a compatibility issue? Else using the default pypi package would make things simpler indeed /cc @manics

@joshmoore
Copy link
Member

  • Point 1: I'm not sure. I'm wondering if we have two different use cases. Once it's been renamed to omero_python_deps we know that we're inside of homebrew whereas when using this raw in OMERO, we don't. In the OMERO case, it seems you don't want to check for bin/pip, highly unlikely to work. In the homebrew case, you actually want to look for $(brew --prefix/bin/pip) I think.
  • Point 2: With newer version of tables, we can probably move away from git.

@joshmoore
Copy link
Member

With ome/openmicroscopy#886 👍

joshmoore added a commit that referenced this pull request Mar 15, 2013
Symlink python_deps.sh and add paragraph in the caveats (see #10649)
@joshmoore joshmoore merged commit e639ee7 into ome:master Mar 15, 2013
@sbesson sbesson deleted the 10469_python_deps branch March 15, 2013 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants