-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlink python_deps.sh and add paragraph in the caveats (see #10649) #25
Conversation
From OMERO-homebrew-develop#19
|
My vote would be to rename |
|
When inside of the ome.git there's no reason to prefix with "omero_" so I'd say just rename in homebrew. |
From OMERO-homebrew-stable#139
|
My only nitpick is that I'm concerned that the script if sourced will execute the current shell. Would you be willing to remove the |
There was a minor issue with Otherwise, location and naming of script seem fine:
Two comments which may be for another PR:
Thoughts? |
@joshmoore: both comments are valid but need to be fixed in a openmicroscopy PR.
|
|
With ome/openmicroscopy#886 👍 |
Symlink python_deps.sh and add paragraph in the caveats (see #10649)
Copy
python_deps.sh
to/usr/local/bin
and add note to caveats.When updating the formula for 4.4.7, we can remove the
if (build.head? or build.devel)?