Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice 3.4 #31

Merged
merged 6 commits into from
May 27, 2013
Merged

Ice 3.4 #31

merged 6 commits into from
May 27, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented May 21, 2013

  • Rename ice.rb as zeroc-ice34 to minimize conflict with mainstream repositories and simplify brew omero --with-ice34 (since Formula.factory() does not properly support tapped names)
  • Fix omero formula when installing with Ice 3.4

These changes should re-enable Ice 3.4 installation which was broken
Reduces confusion with mainstream ice formula which is building 3.5
@joshmoore
Copy link
Member

Has this already made it into a build, @sbesson ?

@sbesson
Copy link
Member Author

sbesson commented May 22, 2013

No waiting for the openmicroscopy homebrew PRs to be merged in first as OMERO-homebrew-install.sh will need extra revamping to test this.
Also we really need to define a strategy for testing these builds as we have only one 10.7 machine on which all the homebrew jobs are currently run sequentially.

@joshmoore
Copy link
Member

@sbesson : cross fingers and merge? Do any other PRs need to be kept in sync?

@sbesson
Copy link
Member Author

sbesson commented May 23, 2013

Two questions at this point regarding Ice Python:

  • should we consistently install the Ice python librbary under #{prefix}/python (instead of #{prefix}/lib/pythonxx/site-packages for the current version of zeroc-ice34) This would simplify the environment variables configuration in the walkthrough/installation script
  • does it make sense to symlink the ZeroC python libraries in the OMERO libraries?

@joshmoore
Copy link
Member

Using OMERO's lib/python directory as an installation location might indeed be a nice compromise.

@sbesson
Copy link
Member Author

sbesson commented May 24, 2013

OK so that's +1 for symlinking. What about the python directory in the Ice 3.4. formula?

@joshmoore
Copy link
Member

Zeroc/python will be there either way, right? Is it just getting symlinked to site-packages? Is the question if we can remove that bit?

@sbesson
Copy link
Member Author

sbesson commented May 24, 2013

Exactly, should we impose consistency in the naming of our python lib directories across our Ice formulas? and if yes which version

  • #{prefix}/python as in current zeroc-ice33
  • #{prefix}/lib/pythonxx/site-packages as in current zero-ice34
  • #{prefix}/lib/python

@joshmoore
Copy link
Member

The "Ice" way is #{prefix}/python, right? If so and that requires the least modification, then I'd probably vote for that.

@sbesson
Copy link
Member Author

sbesson commented May 24, 2013

@joshmoore
Copy link
Member

Excellent. @kennethgillen, now we either need 2x as many boxes for running ice33 and ice34 (and eventually 3x with ice35) or we'll have to start rotating on a daily basis. Monday = ice33, Tuesday = ice34, ... 😄 Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants