Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify version field #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 1, 2023

For the various metadata objects with a version field, this PR makes explicit that version is a string, and that it must be the current version.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Automated Review URLs

@normanrz
Copy link
Contributor

normanrz commented Aug 8, 2023

I wonder if you'd want to integrate that with #206?

@d-v-b
Copy link
Contributor Author

d-v-b commented Aug 8, 2023

Definitely. I see that you are building on #138 -- is there a timeline for getting that finalized (it's been nearly a year)?

@joshmoore
Copy link
Member

is there a timeline for getting that finalized (it's been nearly a year)?

Let's not start that discussion on this thread. Unless there's a major change in priorities, the next major version (0.5) would include transforms and so it makes sense for @normanrz to be building on top of it since the bump to Zarr v3 will need to be its own major version. If you'd still like to target this earlier then I'd suggest not building on top of #206, but 👍 for having them work together to prevent unnecessary churn.

@d-v-b
Copy link
Contributor Author

d-v-b commented Aug 8, 2023

I think the changes here are essentially a patch to the latest version of the spec? So I'm not sure what I should build off other than main?

@joshmoore
Copy link
Member

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants