Skip to content
This repository has been archived by the owner on Jun 26, 2019. It is now read-only.

tiff: Allow flushing of tiles in any order #99

Closed
wants to merge 1 commit into from
Closed

tiff: Allow flushing of tiles in any order #99

wants to merge 1 commit into from

Conversation

rleigh-codelibre
Copy link
Contributor

Closes: #97

Instead of flushing the tiles strictly in index order, flush them as soon as they are covered. This reduces the size of the tile cache, and spreads out disc I/O, if the tiles are written in a different order.

There is no change in usage. The API continues to allow saveBytes to be called in any order and with any size of region, which may or may not overlap with the tile size. The only change is when tiles are flushed from the tile cache, which is now earlier than before for certain usage patterns. All other aspects are unchanged.

Testing: Writing in different orders, including random order, with and without saveBytes regions overlapping tile boundaries, is already handled by the unit tests (tiff), including validation of the pixel data. Check that all builds remain green.

@rleigh-codelibre
Copy link
Contributor Author

By the way, use a whitespace diff for a more readable diff.

@rleigh-codelibre
Copy link
Contributor Author

@joshmoore @sbesson Any chance of getting this one merged? It's going to be a prerequisite for the pyramid writing PR which I would like to open in the next few days.

Thanks,
Roger

@rleigh-codelibre
Copy link
Contributor Author

Closing because it will be incorporated into the subresolution writer changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant