This repository has been archived by the owner on Jun 26, 2019. It is now read-only.
tiff: Allow flushing of tiles in any order #99
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #97
Instead of flushing the tiles strictly in index order, flush them as soon as they are covered. This reduces the size of the tile cache, and spreads out disc I/O, if the tiles are written in a different order.
There is no change in usage. The API continues to allow saveBytes to be called in any order and with any size of region, which may or may not overlap with the tile size. The only change is when tiles are flushed from the tile cache, which is now earlier than before for certain usage patterns. All other aspects are unchanged.
Testing: Writing in different orders, including random order, with and without saveBytes regions overlapping tile boundaries, is already handled by the unit tests (
tiff
), including validation of the pixel data. Check that all builds remain green.