Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Split OS X clients on the downloads page by Java version #134

Merged
merged 9 commits into from
Feb 4, 2015

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jan 29, 2015

Following upstream work in ome/openmicroscopy#3407 and ome/openmicroscopy#3337 two sets of OS X clients are now produced: for Java 6 and Java 7+.

This PR reflects this change by adding an extra row in the clients table of the downloads page.

@sbesson
Copy link
Member Author

sbesson commented Jan 29, 2015

Note:@gusferguson is working on new icons to reflect the different OS X clients.

<strong>1.6</strong> or higher.</p>
</li>
<li>
<p> Mac OS X users should use the clients matching
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a sentence here with a link to http://download.oracle.com/otn-pub/java/jdk/8u31-b13/jre-8u31-macosx-x64.dmg or http://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html e.g. "MacOS X 10.7 and later should install the latest Java and use the Java7+ downloads. MacOS X 10.6 users can only use the Java6 download". This just makes it clearer which versions work with which MacOS X version, and how to get it without reading the docs.

@ghost
Copy link

ghost commented Jan 30, 2015

This looks fine. Just one minor comment about MacOS.

@joshmoore
Copy link
Member

Minor question re: the icon: was omitting the "+" from "Java7" intentional?

@gusferguson
Copy link

Hi Josh - no - will send revised - if I can fit it in!

Regards
Gus

From: Josh Moore <notifications@github.commailto:notifications@github.com>
Reply-To: openmicroscopy/ome-release <reply@reply.github.commailto:reply@reply.github.com>
Date: Fri, 30 Jan 2015 01:47:55 -0800
To: openmicroscopy/ome-release <ome-release@noreply.github.commailto:ome-release@noreply.github.com>
Cc: Gus Ferguson <rkferguson@dundee.ac.ukmailto:rkferguson@dundee.ac.uk>
Subject: Re: [ome-release] Split OS X clients on the downloads page by Java version (#134)

Minor question re: the icon: was omitting the "+" from "Java7" intentional?

Reply to this email directly or view it on GitHubhttps://github.com//pull/134#issuecomment-72177194.

The University of Dundee is a registered Scottish Charity, No: SC015096

@sbesson
Copy link
Member Author

sbesson commented Jan 30, 2015

For pushed with @gusferguson's new icons and the amended OSX text.

@hflynn
Copy link
Member

hflynn commented Jan 30, 2015

Page for RC1 looks good. One minor point for tidiness/consistency - since we now have the second bullet point regarding the Java versions, can you change 'Java Version 1.6 or higher' in the 1st bullet point above to 'Java6 or higher'

@hflynn
Copy link
Member

hflynn commented Jan 30, 2015

Other than that tiny nitpick, looks good!

@sbesson
Copy link
Member Author

sbesson commented Jan 30, 2015

Pushed.

@pwalczysko
Copy link
Member

@sbesson I just discussed with @rleigh-dundee and he suggests to put a link in the downloads page
https://downloads.openmicroscopy.org/omero/5.0.7-rc2/
where it says
Mac OS X users should use the clients matching their installed Java version. MacOS X 10.7 and later should install the latest Java and use the Java 7+ downloads. MacOS X 10.6 users can only use the Java 6 download.
To put the link to the lates Java downloads.
@manics suggests even better…autodetect the user's OS and highlight the appropriate client download

@hflynn
Copy link
Member

hflynn commented Feb 3, 2015

@ghost
Copy link

ghost commented Feb 3, 2015

I suggest "install the latest Java" should be "install the latest Java Runtime Environment (JRE)" so that question of what to download is less confusing. The general index page for downloads has a lot of different download links, so this makes it clearer what to get.

@hflynn
Copy link
Member

hflynn commented Feb 3, 2015

Looks good to me!

@pwalczysko
Copy link
Member

Looks good to me too.

@hflynn
Copy link
Member

hflynn commented Feb 3, 2015

Good to merge once Travis is green

hflynn added a commit that referenced this pull request Feb 4, 2015
Split OS X clients on the downloads page by Java version
@hflynn hflynn merged commit 028b5ef into ome:dev_5_0 Feb 4, 2015
@sbesson sbesson deleted the osx_split branch February 4, 2015 11:38
@sbesson
Copy link
Member Author

sbesson commented Feb 4, 2015

--rebased-to #135

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants