-
Notifications
You must be signed in to change notification settings - Fork 11
Split OS X clients on the downloads page by Java version #134
Conversation
Note:@gusferguson is working on new icons to reflect the different OS X clients. |
<strong>1.6</strong> or higher.</p> | ||
</li> | ||
<li> | ||
<p> Mac OS X users should use the clients matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a sentence here with a link to http://download.oracle.com/otn-pub/java/jdk/8u31-b13/jre-8u31-macosx-x64.dmg or http://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html e.g. "MacOS X 10.7 and later should install the latest Java and use the Java7+ downloads. MacOS X 10.6 users can only use the Java6 download". This just makes it clearer which versions work with which MacOS X version, and how to get it without reading the docs.
This looks fine. Just one minor comment about MacOS. |
Minor question re: the icon: was omitting the "+" from "Java7" intentional? |
Hi Josh - no - will send revised - if I can fit it in! Regards From: Josh Moore <notifications@github.commailto:notifications@github.com> Minor question re: the icon: was omitting the "+" from "Java7" intentional? Reply to this email directly or view it on GitHubhttps://github.com//pull/134#issuecomment-72177194. The University of Dundee is a registered Scottish Charity, No: SC015096 |
For pushed with @gusferguson's new icons and the amended OSX text. |
Page for RC1 looks good. One minor point for tidiness/consistency - since we now have the second bullet point regarding the Java versions, can you change 'Java Version 1.6 or higher' in the 1st bullet point above to 'Java6 or higher' |
Other than that tiny nitpick, looks good! |
Pushed. |
@sbesson I just discussed with @rleigh-dundee and he suggests to put a link in the downloads page |
I suggest "install the latest Java" should be "install the latest Java Runtime Environment (JRE)" so that question of what to download is less confusing. The general index page for downloads has a lot of different download links, so this makes it clearer what to get. |
Looks good to me! |
Looks good to me too. |
Good to merge once Travis is green |
Split OS X clients on the downloads page by Java version
--rebased-to #135 |
Following upstream work in ome/openmicroscopy#3407 and ome/openmicroscopy#3337 two sets of OS X clients are now produced: for Java 6 and Java 7+.
This PR reflects this change by adding an extra row in the clients table of the downloads page.