Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Zarr dev build #251

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

joshmoore
Copy link
Member

This build was put in place by the Zarr team in order to check for potential issues in downstream projects after PRs have been merged. For some reason, it is now aborting with little to no logging. In zarr-developers/zarr-python#1328 the texasbbq package from Numba has been suggested for a similar purpose. This workflow might could be rewritten using such a tool.

This build was put in place by the Zarr team in order to check
for potential issues in downstream projects after PRs have been
merged. For some reason, it is now aborting with little to no
logging. In zarr-developers/zarr-python#1328
the `texasbbq` package from Numba has been suggested for a similar
purpose. This workflow might could be rewritten using such a tool.
@joshmoore
Copy link
Member Author

Now linting is failing!

@will-moore
Copy link
Member

will-moore commented Feb 20, 2023

RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

I think that was fixed with 737228a
since the failure before that commit had that error but after it was something else!

@will-moore
Copy link
Member

All green except test coverage!

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to codecov/codecov-action#598 the test-coverage fail is a flaky issue. Re-running got it green this time!
Good to merge

@will-moore will-moore merged commit 1f47e59 into ome:master Feb 21, 2023
@joshmoore joshmoore deleted the deactivate-dev-build branch February 21, 2023 14:11
@joshmoore joshmoore mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants