Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to codecov 4 #373

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Update to codecov 4 #373

merged 5 commits into from
Apr 24, 2024

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore mentioned this pull request Apr 24, 2024
Open
@joshmoore
Copy link
Member Author

joshmoore commented Apr 24, 2024 •
edited

@will-moore : any ideas here?

@will-moore
Copy link
Member

Looking good. But just the one failure left:

Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

will-moore
will-moore approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joshmoore
Copy link
Member Author

Not sure why env didn't work. Perhaps not in combination with with: 🤷🏽

@joshmoore joshmoore merged commit 1d113cd into ome:master Apr 24, 2024
20 checks passed
@joshmoore joshmoore deleted the codecov-4 branch April 24, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-moore will-moore will-moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmoore @will-moore