Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy<2 in setup.py #385

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

will-moore
Copy link
Member

numpy 2.0.0 has been released with breaking changes. Avoid installing till this can be reviewed etc.
Same as ome/omero-py#414

cc @sbesson

@will-moore will-moore marked this pull request as ready for review June 17, 2024 13:11
@will-moore
Copy link
Member Author

will-moore commented Jun 17, 2024

Tests failing with Error: Codecov token not found. Please provide Codecov token with -t flag.
Reading https://github.com/marketplace/actions/codecov doesn't indicate anything obvious has changed.

What I see at https://github.com/ome/ome-zarr-py/settings doesn't look like https://docs.codecov.com/docs/adding-the-codecov-token - I don't see any tokens etc.

@joshmoore
Copy link
Member

I do see the token, but the environment variable wasn't set. I've pushed a commit that matches what I did in zarr-developers/zarr-python#1647. Waiting to see if it goes green now.

@joshmoore
Copy link
Member

Somehow codecov is only not finding the token on 3.12 (😕) I'm going to merge as is since this is clearly passing most workflows and we may have to come back to it soon.

@joshmoore joshmoore merged commit 9205bd7 into ome:master Jun 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants