Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show labels on plate #62

Merged
merged 3 commits into from Nov 30, 2020
Merged

show labels on plate #62

merged 3 commits into from Nov 30, 2020

Conversation

will-moore
Copy link
Member

Show labels (under each image in a Plate) as a stitched layer on the plate:

@joshmoore I had to do a bunch of hacks here to work around the existing hierarchy traversal, since Plate and PlateLabels are 2 specs based on the same path/to/plate.zarr location.

Maybe I'm thinking this through the wrong way and there's a cleaner way you can think of?

Screenshot 2020-11-17 at 14 36 01

@joshmoore
Copy link
Member

I had to do a bunch of hacks here to work around the existing hierarchy traversal, since Plate and PlateLabels are 2 specs based on the same path/to/plate.zarr location.

Interesting. I'll have a think.

@will-moore will-moore changed the title Initial commit - show labels on plate show labels on plate Nov 20, 2020
@joshmoore joshmoore added this to In progress in OME Zarr HCS (Fall 2020) Nov 23, 2020
@will-moore will-moore marked this pull request as ready for review November 26, 2020 13:08
@will-moore
Copy link
Member Author

When I merge this branch with #61:

*   2e6a7f9 (HEAD -> plate_labels) Merge remote-tracking branch 'draga/add-label-properties' into plate_labels
|\  
| *   309d1fe (draga/add-label-properties) Merge branch 'add-label-properties' of https://github.com/DragaDoncila/ome-zarr-py into add-label-properties
| |\  
| * | 391545c Add test for label properties
* | | 4306bbb (gh/plate_labels) Combine image labels properties into plate metadata

I can test this with:

napari https://s3.embassy.ebi.ac.uk/idr/zarr/v0.1/plates/2551.zarr

Screenshot 2020-11-29 at 22 08 40

@will-moore
Copy link
Member Author

@joshmoore Do I need to add the same as d1b8e37 to this PR to get it green, or will I wait till that one's merged?

@joshmoore
Copy link
Member

Should be fine to wait.

@joshmoore
Copy link
Member

Closing and re-opening to pull in the miniconda update (I hope)

@joshmoore joshmoore closed this Nov 30, 2020
OME Zarr HCS (Fall 2020) automation moved this from In progress to Done Nov 30, 2020
@joshmoore joshmoore reopened this Nov 30, 2020
OME Zarr HCS (Fall 2020) automation moved this from Done to In progress Nov 30, 2020
@joshmoore
Copy link
Member

Green, excellent! Merging & tagging

@joshmoore joshmoore merged commit 1c75f8d into ome:master Nov 30, 2020
OME Zarr HCS (Fall 2020) automation moved this from In progress to Done Nov 30, 2020
@joshmoore joshmoore mentioned this pull request Dec 2, 2020
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/hcs-ome-zarr-data-unable-to-download/57114/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants