Use correct dimension_separator when downsampling #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmoore
approved these changes
May 22, 2023
There was a problem hiding this comment.
👍 for this being similar to https://github.com/ome/ome-zarr-py/pull/243/files (modulo the addition of str(path))
I do wonder if there's anywhere else that this could have cropped up.
|
Fix released in |
|
👍 Shall I export idr0036 with this fix again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a bug introduced in #134
When creating pyramids with
downsample_pyramid_on_disk()theda.to_zarr()doesn't respect dimension separator.For example of data exported with this issue: see https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr0036/zarr/4403.zarr/A/1/0/
Fix is similar to ome/ome-zarr-py#243
To test:
check that array at
123.zarr/1/has dimension separator/