Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conn.SERVICE_OPTS.setOmeroGroup(-1) at login #10

Merged
merged 1 commit into from Jun 12, 2023

Conversation

will-moore
Copy link
Member

This should fix the ValueError: Tag: NO DELETE not found that you get now if your default group is different from the group where that Tag is.

cc @pwalczysko @khaledk2

@pwalczysko
Copy link
Member

tested on latest-ci, with the user ladmin_user which I have removed from the group with the tag. Works as expected. Thank you.

@pwalczysko
Copy link
Member

Do you want to have a look at this fix too @khaledk2 ?

@pwalczysko pwalczysko requested a review from khaledk2 June 7, 2023 18:26
@khaledk2
Copy link

khaledk2 commented Jun 7, 2023

It looks fine. I have tested in the demo server

  • I have edited my profile and restored the previous default group (which was the reason to detect this from the beginning).
  • I have run the plug-in and got the error.
  • I have applied Will's changes on my local venv and run the plug-in again and seems to work fine.

LGTM

@pwalczysko
Copy link
Member

Thanks all. Merging and releasing as 0.2.1

@pwalczysko pwalczysko merged commit 62dbca3 into ome:main Jun 12, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants