Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paragraph about session context and group functionalities #1282

Merged
merged 3 commits into from
Sep 23, 2015

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 22, 2015

Related to the group support improvements in OMERO 5.1.4, this commit mentions
the existence of a context associated to a session and the usage of group
parameter/key value to perform read/write operations in a group different than
the context one.

Related to the group support improvements in OMERO 5.1.4, this commit mentions
the existence of a context associated to a session and the usage of group
parameter/key value to perform read/write operations in a group different than
the context one.
Working in a different group
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Each session is created within a given context defining the session user but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps "...defining not only the..."

@sbesson
Copy link
Member Author

sbesson commented Sep 23, 2015

Working in a different group
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Each session is created within a given context defining not only the session
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a comment after 'contex't here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what comment? did you mean comma?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did & I'm 99% sure that's what I typed - grrr! Soz

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm much less confident about the comma though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed. Should we invoke @hflynn's call on the punctuation question?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be wise.

On 23 Sep 2015, at 11:36, Sébastien Besson <notifications@github.commailto:notifications@github.com> wrote:

In omero/developers/Matlab.txthttps://github.com//pull/1282#discussion_r40189551:

@@ -100,6 +99,27 @@ but it is not configurable from within MATLAB::
c.enableKeepAlive(60); % Call session.keepAlive() every 60 seconds
c.closeSession(); % Close session to end the keep-alive

+Working in a different group
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Each session is created within a given context defining not only the session

Just pushed. Should we invoke @hflynnhttps://github.com/hflynn's call on the punctuation question?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1282/files#r40189551.

@imunro
Copy link

imunro commented Sep 23, 2015

Otherwise looks good to merge.

@hflynn
Copy link
Member

hflynn commented Sep 23, 2015

All good, comma and all ;) Thanks both

hflynn added a commit that referenced this pull request Sep 23, 2015
Add paragraph about session context and group functionalities
@hflynn hflynn merged commit 26fac02 into ome:dev_5_1 Sep 23, 2015
@sbesson sbesson deleted the matlab_group branch September 23, 2015 11:17
@sbesson
Copy link
Member Author

sbesson commented Sep 23, 2015

--rebased-to #1285

@sbesson sbesson added this to the 5.1.4 milestone Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants