-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server installation #2036
Server installation #2036
Conversation
Conflicting PR. Removed from build OMERO-docs-superbuild-push#25. See the console output for more details.
|
My fault, @jburel. I accidentally included files that were code-generated. They've now been removed. |
Thanks |
Following today's discussion, the walkthroughs will need to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally fine.
Just realised I've commented on some of the auto-generated docs...
omero/sysadmins/server-tables.rst
Outdated
@@ -90,7 +90,7 @@ After that, the following should succeed: | |||
your operating system's package installer if possible or if you must | |||
instead use PyPI_ directly:: | |||
|
|||
pip install mock | |||
pip3 install mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI need to be careful with pip
/ pip3
. Sometimes the 3
version is missing from a virtualenv in which case pip3
might refer to a global pip. Something to check later.
@@ -15,11 +15,11 @@ yum -y install java-1.8.0-openjdk | |||
|
|||
# install dependencies | |||
|
|||
yum -y install python-{pip,devel,virtualenv,yaml,jinja2,tables} | |||
yum -y install python3-{pip,devel,virtualenv,yaml,jinja2,tables} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yum -y install python3-{pip,devel,virtualenv,yaml,jinja2,tables} | |
yum -y install python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes are made in omero-install so they will be overridden
@@ -30,8 +30,6 @@ yum -y install libdb-utils | |||
yum -y install openssl-devel bzip2-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these are necessary if everything is installed using wheels
OMERO.server/bin/omero config set omero.db.pass "$OMERO_DB_PASS" | ||
OMERO.server/bin/omero db script -f OMERO.server/db.sql --password "$OMERO_ROOT_PASS" | ||
# set OMERODIR | ||
export OMERODIR=OMERO.server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably safer to use the full absolute path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been changed in omero-install
@@ -18,24 +18,23 @@ apt-get -y install openjdk-8-jre-headless | |||
|
|||
# install dependencies | |||
|
|||
apt-get -y install python-{pip,virtualenv,yaml,jinja2} | |||
apt-get -y install python3-{pip,venv,yaml,jinja2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt-get -y install python3-{pip,venv,yaml,jinja2} | |
apt-get -y install python3-{pip,venv} |
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
@manics changes to the walkthroughs have to be done in omero-install. |
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
Co-Authored-By: Simon Li <orpheus+devel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the office merge this and continue working in separate PRs.
Review installation instructions