Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a OMERO.table visualisation example #2357

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add a OMERO.table visualisation example #2357

wants to merge 4 commits into from

Conversation

fmeyenhofer
Copy link
Contributor

@fmeyenhofer fmeyenhofer commented Nov 5, 2023 •
edited

  • New section with the mechanisms and screenshot
  • Link to the python examples.

As discussed with @will-moore in
https://forum.image.sc/t/omero-tables-display-on-images-link-questions/87870

The updated code examples in #2355 are part of this same issue.

This is the second, revised pull-request replacing #2354.

@fmeyenhofer
Add a OMERO.table visualisation example
2650d55 
- New section with the mechanisms and screenshot
- Link to the python examples.
@fmeyenhofer fmeyenhofer mentioned this pull request Nov 5, 2023
Closed
will-moore
will-moore reviewed Nov 9, 2023
View reviewed changes
omero/developers/Tables.rst Outdated
|- Image 2 <- (Table panel > link, row values)
|- ...

The rows of the table will be rendered for each image of the dataset. The screenshot bellow shows the right-hand side panel of a selected Image in OMERO.web.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "below".
Also nicer to use "Image" and "Dataset" instead of "image" and "dataset". Same with sentence above.

@fmeyenhofer
Update Tables.rst
8e2fb15 
Use capitals for Image and Dataset
@will-moore
Copy link
Member

Just reading the built pages at https://omero--2357.org.readthedocs.build/en/2357/developers/Tables.html
This says you have to attach the Table to a Dataset, but you can also attach it to a Project, Screen or Plate that contains the Images.

@fmeyenhofer
Copy link
Contributor Author

Yes, I was thinking about this in the context of OMERO.parade.
@Rdornier wrote about in his wiki https://wiki-biop.epfl.ch/en/data-management/omero/parade. He mentions possible conflicts about OMERO.tables in OMERO.parade (but this is another topic).

I did not mention the screen-plate-well use case - since I do not have any experience with that yet only just became aware of it.

This should definitely be mentioned.

@will-moore
Copy link
Member

Nice wiki pages on OMERO.parade and other OMERO usage!
@fmeyenhofer So you're going to mention that this works with Project, Screen & Plate?

@fmeyenhofer
Mention all data objects in the OMERO.table visualisation example
afaf2e5 
- Mention Prject, Screen, Plate and well objects.
- Add link to the Screen Plate Well data model
- Add link to OMERO.parade
- Refine text
@fmeyenhofer
Copy link
Contributor Author

Done

will-moore
will-moore approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@will-moore
Copy link
Member

@fmeyenhofer could I ask you to please read and fill-out a CLA form as described at https://ome-contributing.readthedocs.io/en/latest/cla.html - We need this before we can accept contributions to this repo. Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-moore will-moore will-moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmeyenhofer @will-moore