-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bat #6
Fix the bat #6
Conversation
Looks as I would have thought.
I think this is only the case when you are building the downloader from source. |
@joshmoore Added testing steps into description, hope this is as expected (mainly the test 2. where I am trying to mock the structure with the |
I'm concerned about the case where the Update: Sorry, should have woken up more first, obviously I misread the diff: you can ignore this comment. 😃 |
For (2) one can just |
Does the quoting in the |
Testing: should also include running $ foo\ \'\ bar/OMERO.downloader-0.1.2/download.sh ... and it works. (I originally downloaded the artifact from within the directory |
I suppose I have to replace the bat in the release with the one from the PR right? |
Tested on Windows 10. With the bat from this PR:
👍 |
"Cannot create repository links":
|
Yes, both works @mtbc . |
👍 Thank you, it turns out that link-making is an extra special privilege for Windows users! At least we finally have a motivator for the |
It works without it, and I do not know why. |
Definitely something like #6 (comment) at least but @dominikl may have done that already: i.e. something that needs the quoting. |
Maybe move them anyway to keep it all looking the same? Seems to work either way then readers may be less confused about why there's a difference. |
In my testing with Windows Server 2008 (TS-OME-DEV) using paths with spaces in them, this PR's fix does seem to work. |
I suppose the test #6 (comment) is covering the task #6 (comment) ? The last commit should cover the comment #6 (comment) |
Maybe merge then ? |
This should suggest a fix of the
download.bat
script on Windows.The suggested fix is inspired by @joshmoore 's comment pointing to https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tools/OmeroPy/bin/omero.bat
See trello card.
This fix works for me as tested on Windows 7 laptop. Admittedly, I think that I am always testing just the first
if
case, namely, when mydownload.bat
is in the same dir as the jar.But then, I guess this is the more common case.
To be fair, I do not completely understand the second
else if
with thetarget
inside the path - do not see thetarget
defined in that file.See what you think
@joshmoore @mtbc
To test:
download.bat
is.download.bat -b <path-to-directory-you-just-created> -s <server host> -u <user name> -w <password> -f binary Image:<image ID>
download.bat
called "target" and move thedownloader-jar-with-dependencies.jar
into the directory you just created.downloader-jar-with-dependencies.jar
to some other directory than the two dirs described in step 1. and 2. above, or delete it.Failed to find JAR file named downloader-jar-with-dependencies.jar