New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels from tags #254

Merged
merged 2 commits into from Jan 22, 2018

Conversation

Projects
None yet
4 participants
@will-moore
Member

will-moore commented Nov 21, 2017

See https://trello.com/c/ZdmnimZj/64-labels-from-tags

This simply adds a label for every Tag on selected images.

To test:

  • When adding labels, choose [tags] option.
  • Tags added for each label (only 1 label even if multiple users have added the same Tag).
var image_ids = this.map(function(s){return s.get('imageId')})
image_ids = "image=" + image_ids.join("&image=");
// TODO: Use /api/ when annotations is supported
var url = WEBINDEX_URL + "api/annotations/?type=tag&limit=1000&" + image_ids;

This comment has been minimized.

@jburel

jburel Dec 18, 2017

Member

maybe offering the option later on to change the limit.
this will also depend on the number of images

This comment has been minimized.

@will-moore

will-moore Dec 18, 2017

Member

This limit is just a very liberal cut-off to make sure we don't accidentally load millions of annotations, but that scenario is very edge-case.

@pwalczysko

This comment has been minimized.

Member

pwalczysko commented Dec 18, 2017

The functionality works as expected.
Discussing with @will-moore , we went through a round of thinking "what if there are many tags on an image..." but then concluded that in such case, the user would be better off to type the label name manually. The user can also first add all the labels from the tags on the image in question and then delete the labels which do not fit.

Happy to merge FMPOV.

@joshmoore

This comment has been minimized.

Member

joshmoore commented Dec 18, 2017

Can someone paste screenshots here? Are there any doc screenshots which then need updating?

@pwalczysko

This comment has been minimized.

Member

pwalczysko commented Dec 18, 2017

screen shot 2017-12-18 at 16 57 44

@pwalczysko

This comment has been minimized.

Member

pwalczysko commented Dec 18, 2017

@joshmoore see screenshot above. I can see two screenshots needing replacing in http://help.openmicroscopy.org/figure.html#labels section. The screenshots are under points 13. and 15.

@jburel

This comment has been minimized.

Member

jburel commented Dec 20, 2017

Discussed today @will-moore will open a PR to update the screenshot in help

@jburel jburel added this to the 3.2.0 milestone Jan 4, 2018

@jburel

This comment has been minimized.

Member

jburel commented Jan 11, 2018

@will-moore did you have a chance to look at the help PR?

@will-moore

This comment has been minimized.

Member

will-moore commented Jan 11, 2018

I was wondering whether to simply add the "Tags" option to fix existing screenshot (above) or to add the whole "Labels from Tags" workflow.
I'll start anyway...

@will-moore will-moore referenced this pull request Jan 11, 2018

Merged

Figure labels from tags #283

@will-moore

This comment has been minimized.

Member

will-moore commented Jan 11, 2018

Help PR opened at openmicroscopy/ome-help#283

@jburel jburel merged commit 114b340 into ome:master Jan 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment