Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative timestamps format #383

Merged
merged 8 commits into from
May 14, 2020

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented May 10, 2020

Noticed bug with negative timestamps using hh:mm:ss format or mm:ss format since we round the hrs and minutes down in the UI and export script.

To test, check that the timestamps are shown correctly on this figure (screenshot shows current bug) e.g. 0:00:-1 and -1:59:59

Screenshot 2020-05-11 at 00 04 15

@will-moore will-moore mentioned this pull request May 11, 2020
@jburel
Copy link
Member

jburel commented May 12, 2020

Something is out of synch in the display
Screenshot 2020-05-12 at 10 45 54

@jburel
Copy link
Member

jburel commented May 12, 2020

Check the time values one is -00:00:value one is 00:00:-value

will-moore added a commit to will-moore/figure that referenced this pull request May 12, 2020
@will-moore
Copy link
Member Author

@jburel Sorry - didn't list this for standup today but 00:00:-value is fixed in right panel.
One issue I noticed: If you have a negative time (e.g 100 milliseconds) and you show hh:mm:ss`` or ``hh:mm``, they will currently appear as -00:00:00```, which is technically correct (they are negative) but does that look too wrong?

@jburel
Copy link
Member

jburel commented May 13, 2020

Right-hand panel now
Screenshot 2020-05-13 at 11 43 54

@jburel
Copy link
Member

jburel commented May 13, 2020

Screenshot 2020-05-13 at 11 53 51

Having the "negative" zeros do not look good as you say, in that case it should ``00:00``

@will-moore will-moore closed this May 13, 2020
@will-moore will-moore reopened this May 13, 2020
@jburel
Copy link
Member

jburel commented May 14, 2020

This looks better
Screenshot 2020-05-14 at 13 36 16

@jburel
Copy link
Member

jburel commented May 14, 2020

Outside the scope of this PR but for long lasting timelapse [hrs] and [hrs:mins] will be useful

@jburel
Copy link
Member

jburel commented May 14, 2020

Screenshot 2020-05-14 at 13 53 44

@jburel
Copy link
Member

jburel commented May 14, 2020

RFE #384

@jburel jburel merged commit a026de2 into ome:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants